View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003864 | Arch | Bug | public | 2019-02-26 04:39 | 2019-07-30 22:47 |
Reporter | danreb | Assigned To | yorik | ||
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 0.18 | ||||
Summary | 0003864: Arch/BIM wall and roof subtraction : _Roof object as no attribute sub | ||||
Description | Context -------- trying to subtract a roof from a wall in the BIM workbench sample project is attached and the following command can be executed to generate the error (watch the report view output)
| ||||
Steps To Reproduce | Problem -------- in the tree view the wall is displayed whith an error picto and a tooltip message
and the above command generates this output
| ||||
Additional Information | linked to the forum topic https://forum.freecadweb.org/viewtopic.php?f=3&t=33702&p=282951#p282951 My temporary correction ------------------------ changed the code in Arch.roof (line 677)
whith the following ( actually changing the "if self.sub:["whith the "if hasattr (self, "sub"):" hasattr method )
But then the next error is trown when actually recomputing the active document App::Document::_RecomputeFeature(): Unknown exception in Feature "Wall" thrown N.B.: while the error is generated the Walls appears as having being subtracted the volume of the roof. i.e. the errors now comes while recomputing the wall object. | ||||
Tags | Arch, BIM | ||||
FreeCAD Information | |||||
|
|
|
bumping to 0.19 |
|
@yorik can the changes proposed by OP be made in to a PR ? |
|
Sorry, forgot to look at this one... Your proposed changes seem fully correct @danreb however there seem to still be a problem happening, right? I'll have a look at your file ASAP |
|
Ok I was able to fix it fully! https://github.com/FreeCAD/FreeCAD/commit/b03aa051a4aa8ccdb9e16d0f52a297e4cb93a53d |
FreeCAD: master b03aa051 2019-05-07 22:47:15 Yorik van Havre Details Diff |
Arch: Fixed error in roof - Fixes 0003864 |
Affected Issues 0003864 |
|
mod - src/Mod/Arch/ArchRoof.py | Diff File | ||
FreeCAD: releases/FreeCAD-0-18 1fb7ed43 2019-05-08 01:47:15 Yorik van Havre Details Diff |
Arch: Fixed error in roof - Fixes 0003864 |
Affected Issues 0003864 |
|
mod - src/Mod/Arch/ArchRoof.py | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-02-26 04:39 | danreb | New Issue | |
2019-02-26 04:39 | danreb | Tag Attached: 0.18 | |
2019-02-26 04:39 | danreb | Tag Attached: Arch | |
2019-02-26 04:39 | danreb | Tag Attached: BIM | |
2019-02-26 04:39 | danreb | File Added: AbrisCompostBois.FCStd | |
2019-02-26 10:40 | Kunda1 | Status | new => confirmed |
2019-02-26 10:43 | Kunda1 | Steps to Reproduce Updated | |
2019-02-26 10:44 | Kunda1 | Steps to Reproduce Updated | |
2019-02-27 18:07 | wmayer | Project | FreeCAD => Arch |
2019-03-08 19:54 | Kunda1 | Target Version | => 0.19 |
2019-03-08 19:54 | Kunda1 | Note Added: 0012868 | |
2019-03-08 19:55 | Kunda1 | Tag Detached: 0.18 | |
2019-04-06 19:44 | Kunda1 | Note Added: 0013014 | |
2019-05-08 01:42 | yorik | Note Added: 0013083 | |
2019-05-08 01:48 | yorik | Note Added: 0013084 | |
2019-05-08 01:48 | yorik | Assigned To | => yorik |
2019-05-08 01:48 | yorik | Status | confirmed => closed |
2019-05-08 01:48 | yorik | Resolution | open => fixed |
2019-05-08 01:48 | yorik | Fixed in Version | => 0.19 |
2019-07-30 22:47 | Kunda1 | Changeset attached | => FreeCAD releases/FreeCAD-0-18 1fb7ed43 |
2019-07-30 22:47 | Kunda1 | Changeset attached | => FreeCAD master b03aa051 |