View Issue Details

IDProjectCategoryView StatusLast Update
0002881Project Tools & WebsitesFeaturepublic2017-03-13 16:55
ReporterKunda1 Assigned Tokkremitzki  
PrioritynoneSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Summary0002881: MantisBT refinements
Description* @user functionality like github (this will work when mantisb is upgraded to either 1.3.x or 2.0)
* html strikethrough ex.
* allow to read (aka 'uncollapse') text attachments like
** .py
** .log

* Fix the graph pages in Statistics http://freecadweb.org/tracker/plugin.php?page=MantisGraph/summary_jpgraph_page
* Add UTF8 support 0002470
* fix the code markup so that it doesn't highlight empty paragraph space and doesn't offset first character:
Example:

Example
and
Example, Line 1
Line 2


Source-Integration shortcuts: see https://github.com/mantisbt-plugins/source-integration/blob/master/Source/lang/strings_english.txt#L108f
* Test linking to PRs: FreeCAD Pull Request 498
* Test linking to commits: FreeCAD master 709d2f32
* Test link to diff: FreeCAD master 709d2f32
Additional Information* Test linking to commits: FreeCAD master 709d2f32
* Test link to diff: FreeCAD master 709d2f32
* Test linking to PRs: FreeCAD Pull Request 498
TagsNo tags attached.
FreeCAD Information

Relationships

related to 0002470 closedkkremitzki MantisBT needs tables converted to UTF8 
child of 0002846 closedkkremitzki MantisBT Proposal: Default template for bug reports 

Activities

yorik

2017-01-30 00:44

administrator   ~0008095

I dont know what you want me to do here?

Kunda1

2017-01-30 02:42

administrator   ~0008098

Last edited: 2017-01-30 12:00

re: make .log and .py viewable as attachments:
https://www.mantisbt.org/forums/viewtopic.php?f=3&t=23313
Instructions:
In
config_inc.php
find
$g_preview_text_extensions
and please add 'py' and 'log' to the array

Kunda1

2017-01-30 11:59

administrator   ~0008100

Last edited: 2017-01-30 12:00

re: strikethrough in mantisbt:
http://mantisbt.org/forums/viewtopic.php?f=3&t=23221#p57645
Instructions:
In
config_inc.php
find
$g_html_valid_tags
you can add 'del' in there so we can strikethrough text in Mantisbt

yorik

2017-01-30 12:14

administrator   ~0008101

Last edited: 2017-01-30 12:14

Ok both changes above are done
$g_preview_text_extensions = array('', 'txt', 'diff', 'patch' , 'log' , 'py');
$g_html_valid_tags = 'p, li, ul, ol, br, pre, i, b, u, em, strong del';

Kunda1

2017-01-30 20:37

administrator   ~0008112

Last edited: 2017-01-30 20:41

@yorik, you forgot a comma after
strong

Edit:
Re: graphs:
> you must have jpgraph in library folder and on linux has trouble with ttf-fonts (check the apache logs).
mentioned by @Kirill on https://gitter.im/mantisbt/mantisbt

yorik

2017-01-31 20:48

administrator   ~0008138

oh my bad. Done

kkremitzki

2017-02-16 10:22

administrator   ~0008320

@kunda The notification feature should now be working. The graphs look OK to me in the Summary page as well. I can get that UTF8 conversion done next which just leaves a few others.

Kunda1

2017-02-16 11:04

administrator   ~0008321

Last edited: 2017-02-20 03:53

@kkremitzki looks good! Here is some feedback:
1) FreeCAD master 709d2f32 should turn in to a link pointing to FreeCAD github commit 709d2f325 but since it isn't indicates there must be an issue with the source-integration plugin.
2) see attached screenshot which shows the disproportionate table size of activities section in favor of the username icell nstead of the information cell.
3) I'm not certain but attachments may not be working correctly
4) uncollapsing attachements doesn't seem to open them.

mantisbt.png (61,301 bytes)   
mantisbt.png (61,301 bytes)   

kkremitzki

2017-02-16 12:09

administrator  

test.png (32,746 bytes)   
test.png (32,746 bytes)   

kkremitzki

2017-02-19 09:59

administrator  

fib.py (304 bytes)   
def fibonacci():
    a, b = 0, 1
    while True:
        yield a
        a, b = b, a + b


def firstn(g, n):
    for i in range(n):
        yield g.next()


def print_fib(n):
    lst = list(firstn(fibonacci(), n))
    for i in lst:
        print(i)
        

if __name__ == '__main__':
    print_fib(50)
fib.py (304 bytes)   

kkremitzki

2017-02-19 10:07

administrator   ~0008362

def fibonacci():
    a, b = 0, 1
    while True:
        yield a
        a, b = b, a + b


def firstn(g, n):
    for i in range(n):
        yield g.next()


def print_fib(n):
    lst = list(firstn(fibonacci(), n))
    for i in lst:
        print(i)
        

if __name__ == '__main__':
    print_fib(50)

f3nix

2017-02-19 13:08

reporter   ~0008365

Hi.
I have found an issue with password reset.

1. The reset e-mail comes with some closing html tags (reset_mail.png).
2. The password reset link is wrong. There is a semicolon before the "confirm_hash" parameter instead of an ampersand. It leads to "application error number 200".

Cheers,
Mateusz
reset_mail.png (31,333 bytes)   
reset_mail.png (31,333 bytes)   

Kunda1

2017-02-19 16:19

administrator   ~0008370

added https://www.freecadweb.org/wiki/Tracker#MantisBT_Tips_and_Tricks

f3nix

2017-02-19 21:30

reporter   ~0008373

One more issue. The code tag parses the html tags inside it. It does not feel right. Unless there is some option to turn it off.

Eg.
Test Line 1
<br />
<br />
Test Line 2

There are two html _br_ tags inside the _code_ tag.

Cheers,
Mateusz

kkremitzki

2017-02-20 03:18

administrator   ~0008380

@f3nix the br tags working is intentional, there is a setting to whitelist certain HTML tags, referred to in 0002881:0008101

Kunda1

2017-02-20 22:40

administrator   ~0008392

FreeCAD Pull Request 539

kkremitzki

2017-02-21 00:29

administrator   ~0008393

The email issue was resolved by @Kunda1, the PR link not working is an upstream (and soon to be gone) bug, and the database UTF-8 conversion is a separate issue, so I'm going to close this as resolved. Any subsequent issues should just get created as a new issue in the "Project tools" project and assigned to me.

kkremitzki

2017-02-21 00:31

administrator   ~0008394

Last edited: 2017-02-21 00:32

I also created 0002911 to track the image previews not working.

kkremitzki

2017-02-21 00:33

administrator   ~0008395

Majority of sub-issues resolved; persistent ones separated into separate issues; new issues with tracker should be created as standalone.

Issue History

Date Modified Username Field Change
2017-01-29 19:45 Kunda1 New Issue
2017-01-29 19:45 Kunda1 Issue generated from: 0002846
2017-01-29 19:45 Kunda1 Relationship added child of 0002846
2017-01-29 19:46 Kunda1 Relationship added related to 0002470
2017-01-29 19:46 Kunda1 Description Updated
2017-01-29 19:48 Kunda1 Description Updated
2017-01-29 19:48 Kunda1 Assigned To => yorik
2017-01-29 19:48 Kunda1 Status new => assigned
2017-01-30 00:44 yorik Note Added: 0008095
2017-01-30 02:42 Kunda1 Note Added: 0008098
2017-01-30 11:59 Kunda1 Note Added: 0008100
2017-01-30 12:00 Kunda1 Note Edited: 0008098
2017-01-30 12:00 Kunda1 Note Edited: 0008100
2017-01-30 12:14 yorik Note Added: 0008101
2017-01-30 12:14 yorik Note Edited: 0008101
2017-01-30 20:37 Kunda1 Note Added: 0008112
2017-01-30 20:40 Kunda1 Note Edited: 0008112
2017-01-30 20:40 Kunda1 Note Edited: 0008112
2017-01-30 20:41 Kunda1 Note Edited: 0008112
2017-01-31 19:24 Kunda1 Description Updated
2017-01-31 20:48 yorik Note Added: 0008138
2017-02-03 23:36 Kunda1 Description Updated
2017-02-03 23:36 Kunda1 Description Updated
2017-02-03 23:37 Kunda1 Description Updated
2017-02-03 23:37 Kunda1 Description Updated
2017-02-03 23:37 Kunda1 Description Updated
2017-02-03 23:39 Kunda1 Description Updated
2017-02-03 23:39 Kunda1 Description Updated
2017-02-03 23:40 Kunda1 Description Updated
2017-02-03 23:40 Kunda1 Description Updated
2017-02-03 23:41 Kunda1 Description Updated
2017-02-03 23:43 Kunda1 Description Updated
2017-02-03 23:45 Kunda1 Description Updated
2017-02-04 00:19 Kunda1 Description Updated
2017-02-16 08:27 kkremitzki Assigned To yorik => kkremitzki
2017-02-16 10:22 kkremitzki Note Added: 0008320
2017-02-16 11:04 Kunda1 File Added: mantisbt.png
2017-02-16 11:04 Kunda1 Note Added: 0008321
2017-02-16 11:05 Kunda1 Note Edited: 0008321
2017-02-16 11:06 Kunda1 Description Updated
2017-02-16 11:07 Kunda1 Note Edited: 0008321
2017-02-16 12:09 kkremitzki File Added: test.png
2017-02-19 09:59 kkremitzki File Added: fib.py
2017-02-19 10:07 kkremitzki Note Added: 0008362
2017-02-19 13:08 f3nix File Added: reset_mail.png
2017-02-19 13:08 f3nix Note Added: 0008365
2017-02-19 14:57 Kunda1 Description Updated
2017-02-19 16:19 Kunda1 Note Added: 0008370
2017-02-19 21:30 f3nix Note Added: 0008373
2017-02-20 03:18 kkremitzki Note Added: 0008380
2017-02-20 03:53 Kunda1 Note Edited: 0008321
2017-02-20 20:58 kkremitzki Project FreeCAD => Project Tools & Websites
2017-02-20 22:40 Kunda1 Note Added: 0008392
2017-02-21 00:29 kkremitzki Note Added: 0008393
2017-02-21 00:31 kkremitzki Note Added: 0008394
2017-02-21 00:32 kkremitzki Note Edited: 0008394
2017-02-21 00:33 kkremitzki Status assigned => resolved
2017-02-21 00:33 kkremitzki Resolution open => fixed
2017-02-21 00:33 kkremitzki Note Added: 0008395
2017-02-21 00:33 kkremitzki Status resolved => closed
2017-03-13 16:02 Kunda1 Additional Information Updated