FreeCAD|
|
3_point_circle.png (54,517 bytes) |
|
|
Here is a picture of the tool in solidworks. |
|
|
This is where it is implemented. https://github.com/mdinger/FreeCAD_sf_master/tree/3_point_circle |
|
|
I think I have it mostly implemented except for a better icon. The icon stacking seems to work fine but I don't really understand it well. However, it should be fine because it's copy paste from the 3 point arc tool. Regardless, you may want to look at it before you accept it (if you accept it). It has these implemented: 1. Stacked icons 2. All 3 points auto-snap 3. Tool is enabled on the right click menu 4. Tool is in the Sketcher menu 5. Tool is in both "Part Design" and "Sketcher" toolbars |
|
|
I'll have a look at it at the weekend... |
|
|
I don't think it needs to merge yet. I still want to make a few modifications. |
|
|
OK, just post here when it's ready for merge. |
|
|
I state below why I disabled tangency on the first 2 points: Here is a video where I point out some differences between how Creo and SolidWorks implement their 3 point circle tool. Once subtitles get in the way of the video. I tried to move them and succeeded but couldn't get it into a format youtube accepts. Took me so long I decided to leave it as is. http://youtu.be/1p6BjqYXRPU Solidworks, to allow tangency on the first 2 auto-snaps, modifies their preview type (between tangent or not) on the fly. This can make the tool jump around a lot depending on what passes under the mouse. Sometimes it will make it hard to use. Creo avoids it entirely by first, not allowing tangent on the first 2 points. Second, they allow it on the last point _only_ when the _arc_ is already tangent. This makes the tool predictable. Creo also provides a different too, a 3_tangent_circle_tool if 3 tangents are specifically desired. Creo's design does have a downside. The arc snaps instead of the mouse which makes it snap much more often because the arc is bigger. This can make the mouse feel really sluggish/jittery. I can make it behave like SolidWorks but I think it can be unpredictable and that isn't good. Since the circle preview won't look tangent for the first 2 points, I am disabling it for them. I can allow the third to be tangent because it is the last and unlikely to adjust the curve as much. On another note, it might be a good idea to make objects snap like Creo instead of only the mouse. I'm not sure if they should but it might be good. Recap SolidWorks/Creo: 1. SolidWorks' tangency preview accurately shows the resulting circle 2. SolidWorks' tangency preview can make sometimes make drawing difficult 3. Creo doesn't allow tangency on the first 2 points 4. Creo auto-snaps on the circle and not on the mouse 5. Creo is more predictable because of these choices Recap FreeCAD: 1. Don't allow tangency on first 2 points 2. Allow tangency on the third 3. Possibly enable snapping on the circle instead of the on the mouse in the future |
|
|
I submitted a pull request here. Please merge: https://github.com/FreeCAD/FreeCAD_sf_master/pull/20 Here is the forum thread which discussed this feature for future reference: http://forum.freecadweb.org/viewtopic.php?f=10&t=6146 |
|
|
Please mark "Fixed in Version" 0.14 |
- Anonymous
