FreeCADView Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004422 | PartDesign | Bug | public | 2020-08-21 21:22 | 2020-09-14 09:00 |
| Reporter | JGeo | Assigned To | wmayer | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Windows | OS | Windows 10 | OS Version | 64-bit |
| Summary | 0004422: PartDesign value input does not accept trailing slash | ||||
| Description | Other math symbols like +, -, and * are accepted, but not a / as math symbol when typing a numeric value for some constraint, like the radius of a circle or a distance measure. However, sometimes you want to enter the diameter divided by 2, for example. Entering "14/2" does not work, as the "/" is not accepted after the "14". The only way to achieve this is typing "142", then placing the carer one character to the left, and entering the "/" to get "14/2". This is not very intuitive nor convenient. I suppose a syntax checker is running while entering the numeric values, to check for valid numerical entries. However, it is possible to type "7*2" at once, so there must be some regular expression that accepts a *+- but not a /, probably because / is an escape character in a regular expression. | ||||
| Steps To Reproduce |
| ||||
| Tags | #pending-forum | ||||
| FreeCAD Information | OS: Windows 10 (10.0) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.19.22234 (Git) Build type: Release Branch: master Hash: 068bfc2ebeab8577608f2bdd47200a141dd02c02 Python version: 3.8.5 Qt version: 5.12.5 Coin version: 4.0.0 OCC version: 7.4.0 Locale: English/United States (en_US) | ||||
|
|
Seems it's caused by some violations of the input syntax rules. Since when I delete the 'mm' unit after the number, I can input '/' after the number. And If the '/' exists at the end of the input box, 'm' is not accepted any more. |
|
|
I'll verify this bug report. I've noticed the same thing using imperial units. if (in) or (") is at the end of the string you can not type a / slash. Remove the measurement tag and you can enter a / |
|
|
@JGeo Thanks for the effort in creating a bug report. Did you miss the yellow banner at the top? Next time, please open a forum thread to discuss bugs before opening a ticket. Do you mind going ahead and x-posting to the forum (add links to forum and this ticket so we can track the discussion). Thanks. @jasincole thanks for confirming. Please always post your full 'About' information so we know in what context you're re-creating the bug. |
|
|
Would this be a good first issue for a beginning FreeCAD contributor? |
|
|
@bananu7 possibly, the PartDesign code IIRC is in c++ You can open a forum thread to discuss this to see if it makes sense to mark it with the 'low-hanging fruit' tag |
|
|
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=50189 |
|
|
https://github.com/FreeCAD/FreeCAD/commit/d20512216052f049ac76311a9c825852daf712e5 |
|
|
Fix committed to master branch. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-08-21 21:22 | JGeo | New Issue | |
| 2020-08-25 10:14 | Junzo Gordon | Note Added: 0014711 | |
| 2020-08-25 16:33 | jasincole | Note Added: 0014712 | |
| 2020-08-26 11:54 | Kunda1 | Note Added: 0014718 | |
| 2020-08-26 11:54 | Kunda1 | Tag Attached: #post-to-forum | |
| 2020-09-09 20:34 | bananu7 | Note Added: 0014730 | |
| 2020-09-10 14:51 | Kunda1 | Note Added: 0014732 | |
| 2020-09-13 21:55 | Kunda1 | Note Added: 0014752 | |
| 2020-09-13 21:56 | Kunda1 | Tag Detached: #post-to-forum | |
| 2020-09-13 21:56 | Kunda1 | Tag Attached: #pending-forum | |
| 2020-09-14 08:48 | wmayer | Assigned To | => wmayer |
| 2020-09-14 08:48 | wmayer | Status | new => closed |
| 2020-09-14 08:48 | wmayer | Resolution | open => fixed |
| 2020-09-14 08:48 | wmayer | Fixed in Version | => 0.19 |
| 2020-09-14 08:48 | wmayer | Note Added: 0014753 | |
| 2020-09-14 09:00 | wmayer | Changeset attached | => FreeCAD master d2051221 |
| 2020-09-14 09:00 | wmayer | Note Added: 0014754 |
