View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004228 | FreeCAD | Bug | public | 2019-12-17 03:20 | 2020-03-24 10:54 |
Reporter | Kunda1 | Assigned To | keithsloan52 | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Summary | 0004228: LGTM: OpenSCAD/ply/yacc.py: __getslice__ method has been deprecated since Python 2.0 | ||||
Description | Details: https://lgtm.com/projects/g/FreeCAD/FreeCAD/snapshot/1a82a5e136d24ed9862c0fd7e41070049a23fa32/files/src/Mod/OpenSCAD/ply/yacc.py?sort=name&dir=ASC&mode=heatmap#xf5f1a593d248c644:1 | ||||
Tags | #tobeclosed | ||||
FreeCAD Information | See link above | ||||
|
CC @keithsloan52 care to weigh in ? Edit: Solution: https://lgtm.com/rules/9980084/ |
|
There is a separate issue: https://lgtm.com/projects/g/FreeCAD/FreeCAD/snapshot/1a82a5e136d24ed9862c0fd7e41070049a23fa32/files/src/Mod/OpenSCAD/ply/yacc.py#x14e49d19a7e18da9:1 Shall I open a new ticket or should we keep all the LGTM issues in one ticket ? |
|
Not sure what version I used but it was a long time ago and have not updated on the basis if it ain't broke don't fix it. Latest version seems to be PLY-3.11 see https://www.dabeaz.com/ply/ I am at Texas2019 in Portsmouth this week. Any chance you could update and test. Otherwise I can look at it this coming weekend. Same goes for other similar problem. |
|
Okay just checked the version being used is 3.4 and the latest is 3.11 |
|
@keithsloan52 thanks for checking! What's next ? |
|
Have updated https://github.com/KeithSloan/FreeCAD_sf_master with PLY 3.11 and made pull request. Not able to easily test as would mean building all of FreeCAD prereq as well as FreeCAD. Would you be able to test i.e. just try importing any old csg or scad file. |
|
@keithsloan52 currently my machine is not functioning correctly. So I'm in an interim phase between machines. In other words, I can't test ATM. Should we open a forum thread to see who can? Or do you have anyone else in mind that can ? |
|
Just had a look on my system at /usr/lib/freecad/Mod/OpenSCAD and there is NO !! ply directory. Yet it loads and parses files okay. Which is at OS: Ubuntu 18.04.3 LTS Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.18.3. Build type: Release Python version: 3.6.8 Qt version: 5.9.5 Coin version: 4.0.0a OCC version: 7.3.0 Locale: English/UnitedKingdom (en_GB) Looking at /usr/lib/freecad-daily/Mod/OpenSCAD and it does have a ply directory. The contents are 3.4 i.e. What I setup ages ago. My freecad-daily is well out of date OS: Ubuntu 18.04.3 LTS (ubuntu:GNOME/ubuntu) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.19. Build type: Release Python version: 3.6.8 Qt version: 5.9.5 Coin version: 4.0.0a OCC version: 7.3.0 Locale: English/UnitedKingdom (en_GB) So it looks to me that somebody ( Not me ) has installed ply as part of FreeCAD. If that is the case then that is the version of ply that needs to be the latest 3.11. Any ideas of who that is or what is going on? |
|
FreeCAD master 6d2742c0 |
|
Should be fixed |
|
Okay I have removed ply from the OpenSCAD directory and made a new pull request. Glad it all got sorted in the end. |
|
Needed a later version of Ply. Ply is used by other parts of FreeCAD so no need for a version in OpenSCAD workbench |
FreeCAD: master 6d2742c0 2020-01-12 12:25:44 Committer: yorik Details Diff |
Update Ply to 3.11 |
Affected Issues 0004228 |
|
mod - src/Mod/OpenSCAD/ply/ANNOUNCE | Diff File | ||
mod - src/Mod/OpenSCAD/ply/CHANGES | Diff File | ||
rm - src/Mod/OpenSCAD/ply/PKG-INFO | Diff File | ||
rm - src/Mod/OpenSCAD/ply/TODO | Diff File | ||
mod - src/Mod/OpenSCAD/ply/__init__.py | Diff File | ||
add - src/Mod/OpenSCAD/ply/cpp.py | Diff File | ||
add - src/Mod/OpenSCAD/ply/ctokens.py | Diff File | ||
mod - src/Mod/OpenSCAD/ply/lex.py | Diff File | ||
add - src/Mod/OpenSCAD/ply/setup.cfg | Diff File | ||
mod - src/Mod/OpenSCAD/ply/setup.py | Diff File | ||
mod - src/Mod/OpenSCAD/ply/yacc.py | Diff File | ||
add - src/Mod/OpenSCAD/ply/ygen.py | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-12-17 03:20 | Kunda1 | New Issue | |
2019-12-17 03:20 | Kunda1 | Note Added: 0013919 | |
2019-12-17 03:21 | Kunda1 | Note Edited: 0013919 | |
2019-12-17 03:30 | Kunda1 | Note Added: 0013920 | |
2019-12-17 07:01 | keithsloan52 | Note Added: 0013927 | |
2019-12-17 07:04 | keithsloan52 | Note Added: 0013928 | |
2019-12-17 20:33 | keithsloan52 | Note Edited: 0013927 | |
2020-01-11 12:19 | Kunda1 | Note Added: 0014043 | |
2020-01-12 12:37 | keithsloan52 | Note Added: 0014061 | |
2020-01-12 13:09 | Kunda1 | Note Added: 0014062 | |
2020-01-12 13:59 | keithsloan52 | Note Added: 0014064 | |
2020-01-12 14:00 | keithsloan52 | Note Edited: 0014064 | |
2020-01-15 21:01 | Kunda1 | Tag Attached: #tobeclosed | |
2020-01-15 21:06 | Kunda1 | Note Added: 0014079 | |
2020-01-15 21:06 | Kunda1 | Note Edited: 0014079 | |
2020-01-15 21:06 | Kunda1 | Changeset attached | => FreeCAD master 6d2742c0 |
2020-01-15 21:07 | Kunda1 | Note Added: 0014080 | |
2020-01-15 21:07 | Kunda1 | Assigned To | => keithsloan52 |
2020-01-15 21:07 | Kunda1 | Status | new => assigned |
2020-01-15 21:26 | keithsloan52 | Note Added: 0014081 | |
2020-03-24 10:54 | keithsloan52 | Status | assigned => closed |
2020-03-24 10:54 | keithsloan52 | Resolution | open => fixed |
2020-03-24 10:54 | keithsloan52 | Note Added: 0014275 |