View Issue Details

IDProjectCategoryView StatusLast Update
0002524FreeCADFeaturepublic2016-10-08 01:21
Reporteryorik Assigned Toyorik  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
PlatformPCOSDebianOS VersionTesting 64bit
Target Version0.17 
Summary0002524: Make property docstrings translatable
DescriptionUpgrade FeaturePython::addProperty method to support unicode
Additional Informationhttp://forum.freecadweb.org/viewtopic.php?f=3&t=14914
TagsNo tags attached.
FreeCAD Information

Activities

yorik

2016-05-18 20:03

administrator   ~0007112

Last edited: 2016-05-18 20:04

I now changed the strategy: It is wrong to translate the properties docstrings when adding properties to features. Because by doing that, the translated string is written into the file, so a user from another country could open a file and get a property whose docstring is in an ununderstandable language.

A much better way would be to use the same system as for commands (QtCore.QT_TRANSLATE_NOOP) and have the property docstring translated when showing it in the FreeCAD interface only.

For now, I removed all docstring translations, which will solve the errors mentioned in the linked topic.

wmayer

2016-09-08 08:38

administrator   ~0007310

Important for this to work is that the context string used for QT_TRANSLATE_NOOP is everywhere the same because the property editor has no knowledge where the strings come from. What about using "CustomProperty" as context?

yorik

2016-09-08 14:02

administrator   ~0007311

Yes I was thinking about that too... or "PropertyDescription"

wmayer

2016-09-08 16:33

administrator   ~0007312

I think PropertyDescription is a bit long and is too tight with the doc string. One could also think about making the group name translatable. Therefore I chose the prefix "App::Property".

yorik

2016-09-08 19:39

administrator   ~0007313

Wow, thanks a lot! I would have taken a lot of time to find out how to do it...
I'll keep this opened until I added the QT_TRANSLATE_NOOP in python scripts

Related Changesets

FreeCAD: master e6dd3488

2016-05-18 21:59:15

yorik

Details Diff
removed translation from property descriptions (wrong to do it there anyway) - issue 0002524 Affected Issues
0002524
mod - src/Mod/Arch/ArchAxis.py Diff File
mod - src/Mod/Arch/ArchBuilding.py Diff File
mod - src/Mod/Arch/ArchComponent.py Diff File
mod - src/Mod/Arch/ArchEquipment.py Diff File
mod - src/Mod/Arch/ArchFloor.py Diff File
mod - src/Mod/Arch/ArchPanel.py Diff File
mod - src/Mod/Arch/ArchRoof.py Diff File
mod - src/Mod/Arch/ArchSectionPlane.py Diff File
mod - src/Mod/Arch/ArchSite.py Diff File
mod - src/Mod/Arch/ArchSpace.py Diff File
mod - src/Mod/Arch/ArchStairs.py Diff File
mod - src/Mod/Arch/ArchStructure.py Diff File
mod - src/Mod/Arch/ArchWall.py Diff File
mod - src/Mod/Arch/ArchWindow.py Diff File
mod - src/Mod/Fem/_ViewProviderFemAnalysis.py Diff File
mod - src/Mod/Path/PathScripts/PathComment.py Diff File
mod - src/Mod/Path/PathScripts/PathCompoundExtended.py Diff File
mod - src/Mod/Path/PathScripts/PathCopy.py Diff File
mod - src/Mod/Path/PathScripts/PathDressup.py Diff File
mod - src/Mod/Path/PathScripts/PathDrilling.py Diff File
mod - src/Mod/Path/PathScripts/PathFixture.py Diff File
mod - src/Mod/Path/PathScripts/PathFromShape.py Diff File
mod - src/Mod/Path/PathScripts/PathHop.py Diff File
mod - src/Mod/Path/PathScripts/PathKurve.py Diff File
mod - src/Mod/Path/PathScripts/PathLoadTool.py Diff File
mod - src/Mod/Path/PathScripts/PathMachine.py Diff File
mod - src/Mod/Path/PathScripts/PathPlane.py Diff File
mod - src/Mod/Path/PathScripts/PathPocket.py Diff File
mod - src/Mod/Path/PathScripts/PathProfile.py Diff File
mod - src/Mod/Path/PathScripts/PathProject.py Diff File
mod - src/Mod/Path/PathScripts/PathStock.py Diff File
mod - src/Mod/Path/PathScripts/PathStop.py Diff File
mod - src/Mod/Path/PathScripts/PathToolLenOffset.py Diff File

FreeCAD: master 61f663d1

2016-09-08 18:29:27

wmayer

Details Diff
issue 0002524: Make property docstrings translatable Affected Issues
0002524
mod - src/Gui/ViewProviderOrigin.cpp Diff File
mod - src/Gui/ViewProviderOriginFeature.cpp Diff File
mod - src/Gui/propertyeditor/PropertyItem.cpp Diff File
mod - src/Mod/Path/PathScripts/PathMachine.py Diff File

FreeCAD: master dabccc40

2016-10-08 02:37:15

yorik

Details Diff
Made Arch objects properties translatable - issue 0002524 Affected Issues
0002524
mod - src/Mod/Arch/ArchAxis.py Diff File
mod - src/Mod/Arch/ArchBuilding.py Diff File
mod - src/Mod/Arch/ArchComponent.py Diff File
mod - src/Mod/Arch/ArchEquipment.py Diff File
mod - src/Mod/Arch/ArchFloor.py Diff File
mod - src/Mod/Arch/ArchFrame.py Diff File
mod - src/Mod/Arch/ArchPanel.py Diff File
mod - src/Mod/Arch/ArchPipe.py Diff File
mod - src/Mod/Arch/ArchPrecast.py Diff File
mod - src/Mod/Arch/ArchProfile.py Diff File
mod - src/Mod/Arch/ArchRebar.py Diff File
mod - src/Mod/Arch/ArchRoof.py Diff File
mod - src/Mod/Arch/ArchSchedule.py Diff File
mod - src/Mod/Arch/ArchSectionPlane.py Diff File
mod - src/Mod/Arch/ArchServer.py Diff File
mod - src/Mod/Arch/ArchSite.py Diff File
mod - src/Mod/Arch/ArchSpace.py Diff File
mod - src/Mod/Arch/ArchStairs.py Diff File
mod - src/Mod/Arch/ArchStructure.py Diff File
mod - src/Mod/Arch/ArchWall.py Diff File
mod - src/Mod/Arch/ArchWindow.py Diff File
mod - src/Mod/Arch/InitGui.py Diff File

FreeCAD: master 17a24a4b

2016-10-08 02:55:26

yorik

Details Diff
Made Draft objects properties translatable - issue 0002524 Affected Issues
0002524
mod - src/Mod/Draft/Draft.py Diff File

FreeCAD: master a50bd5dc

2016-10-08 03:21:02

yorik

Details Diff
Made Path objects properties translatable - fixes 0002524 Affected Issues
0002524
mod - src/Mod/Draft/Draft.py Diff File
mod - src/Mod/Path/PathScripts/DragknifeDressup.py Diff File
mod - src/Mod/Path/PathScripts/PathArray.py Diff File
mod - src/Mod/Path/PathScripts/PathComment.py Diff File
mod - src/Mod/Path/PathScripts/PathCompoundExtended.py Diff File
mod - src/Mod/Path/PathScripts/PathCopy.py Diff File
mod - src/Mod/Path/PathScripts/PathCustom.py Diff File
mod - src/Mod/Path/PathScripts/PathDressup.py Diff File
mod - src/Mod/Path/PathScripts/PathDrilling.py Diff File
mod - src/Mod/Path/PathScripts/PathEngrave.py Diff File
mod - src/Mod/Path/PathScripts/PathFacePocket.py Diff File
mod - src/Mod/Path/PathScripts/PathFaceProfile.py Diff File
mod - src/Mod/Path/PathScripts/PathFixture.py Diff File
mod - src/Mod/Path/PathScripts/PathFromShape.py Diff File
mod - src/Mod/Path/PathScripts/PathHop.py Diff File
mod - src/Mod/Path/PathScripts/PathLoadTool.py Diff File
mod - src/Mod/Path/PathScripts/PathMachine.py Diff File
mod - src/Mod/Path/PathScripts/PathPlane.py Diff File
mod - src/Mod/Path/PathScripts/PathPocket.py Diff File
mod - src/Mod/Path/PathScripts/PathProfile.py Diff File
mod - src/Mod/Path/PathScripts/PathProject.py Diff File
mod - src/Mod/Path/PathScripts/PathRemote.py Diff File
mod - src/Mod/Path/PathScripts/PathStock.py Diff File
mod - src/Mod/Path/PathScripts/PathStop.py Diff File
mod - src/Mod/Path/PathScripts/PathSurface.py Diff File
mod - src/Mod/Path/PathScripts/PathToolLenOffset.py Diff File

Issue History

Date Modified Username Field Change
2016-04-26 22:36 yorik New Issue
2016-04-26 22:36 yorik Status new => assigned
2016-04-26 22:36 yorik Assigned To => yorik
2016-05-18 19:59 yorik Changeset attached => FreeCAD Master master e6dd3488
2016-05-18 20:03 yorik Note Added: 0007112
2016-05-18 20:03 yorik Summary Add unicode support to FeaturePython::AddProperty => Make property docstrings translatable
2016-05-18 20:04 yorik Note Edited: 0007112
2016-09-08 08:38 wmayer Note Added: 0007310
2016-09-08 14:02 yorik Note Added: 0007311
2016-09-08 16:30 wmayer Changeset attached => FreeCAD Master master 61f663d1
2016-09-08 16:33 wmayer Note Added: 0007312
2016-09-08 19:39 yorik Note Added: 0007313
2016-10-08 01:21 yorik Changeset attached => FreeCAD Master master dabccc40
2016-10-08 01:21 yorik Changeset attached => FreeCAD Master master 17a24a4b
2016-10-08 01:21 yorik Changeset attached => FreeCAD Master master a50bd5dc
2016-10-08 01:21 yorik Status assigned => closed
2016-10-08 01:21 yorik Resolution open => fixed