FreeCADView Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001841 | Arch | Bug | public | 2014-12-01 00:39 | 2015-01-03 18:09 |
| Reporter | bofhjr | Assigned To | yorik | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | any | OS | any | OS Version | any |
| Product Version | 0.14 | ||||
| Summary | 0001841: Clone of window cannot be fully aggregated into host wall | ||||
| Description | Freecad is unable to calculate the clone subvolume : Traceback (most recent call last): File "/home/me/src/git/free-cad-code/build/Mod/Arch/ArchWall.py", line 473, in execute base = self.processSubShapes(obj,base,pl) File "/home/me/src/git/free-cad-code/build/Mod/Arch/ArchComponent.py", line 584, in processSubShapes f = o.Proxy.getSubVolume(o) <type 'exceptions.AttributeError'>: _Clone instance has no attribute 'getSubVolume' | ||||
| Steps To Reproduce | See attached file : the clone window is within the wall group but no opening can be created for it. | ||||
| Tags | No tags attached. | ||||
| FreeCAD Information | |||||
|
|
|
|
|
|
|
|
|
|
|
I tried to correct the problem : see the two last filesI uploaded (0001-XXX and 0002-YY)... These files are git patch files against the last head commit (640c9cbf8b5ac7811badd5ffd06aa65a5feb95ca). What I did is first to add a getSubvolume method to the _Clone class in Draft.py and nexy to correct some tests against window types in ArchComponent.py. I defined also a method isCLoneRec in Draft.py as I plan to use at least two levels of windiw clones .e. "Clone of Clone of window"). Next I corrected an unrelated typo in ArchComponent (one use of "placemen" instead of "placement"). Regards, Jean-Marie |
|
|
Cool, thanks for the work! I'll review and merge this ASAP. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-12-01 00:39 | bofhjr | New Issue | |
| 2014-12-01 00:39 | bofhjr | File Added: ProblemeCLoneWindowSubVolume.fcstd | |
| 2014-12-02 04:12 | bofhjr | File Added: 0001-Aggrgation-Mur-clones-rec-de-fenetres.patch | |
| 2014-12-02 04:13 | bofhjr | File Added: 0002-rendre-getSubvolume-seulement-applicable-aux-fenetre.patch | |
| 2014-12-02 04:28 | bofhjr | Note Added: 0005349 | |
| 2014-12-03 23:59 | yorik | Note Added: 0005353 | |
| 2014-12-03 23:59 | yorik | Assigned To | => yorik |
| 2014-12-03 23:59 | yorik | Status | new => assigned |
| 2015-01-03 18:09 | yorik | Changeset attached | => FreeCAD Master master 9b9526e4 |
| 2015-01-03 18:09 | yorik | Status | assigned => closed |
| 2015-01-03 18:09 | yorik | Resolution | open => fixed |
