0004371: Changing Hole profile from ISO to nothing is not possible: "Hole: Cannot get value from invalid enumeration"

ID	Project	Category	View Status	Date Submitted	Last Update

0004371	PartDesign	Bug	public	2020-06-13 21:50	2020-10-19 14:53

Reporter	n.rottgardt@gmail.com	Assigned To	wmayer
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed

Summary	0004371: Changing Hole profile from ISO to nothing is not possible: "Hole: Cannot get value from invalid enumeration"
Description	Changing a hole from profile Iso to Nothing runs into the error message: "Hole: Cannot get value from invalid enumeration". It is not possible to confirm the ch 204.555 <App> Document.cpp(3732): Failed to recompute Soxos_GPS_Halter_4_1#Hole: Cannot get value from invalid enumeration Thread size out of range Unhandled Base::Exception caught in GUIApplication::notify. The error message is: Thread size out of range <Exception> Thread size out of range
Steps To Reproduce	Try to change a hole with profile Iso back to nothing (example attached). Try to change feature "Bohrungen" back to profile nothing.
Additional Information	Forum: https://forum.freecadweb.org/viewtopic.php?f=13&t=47584
Tags	No tags attached.

FreeCAD Information	OS: Windows 10 (10.0) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.19.21514 (Git) Build type: Release Branch: master Hash: 89ddab33f692a9bd739171689f9ab0eb58d64b35 Python version: 3.8.2 Qt version: 5.12.5 Coin version: 4.0.0 OCC version: 7.4.0 Locale: German/Germany (de_DE)

FreeCAD: master fe3f1b51 2020-09-23 09:11:27 wmayer Details Diff	PartDesign: [skip ci] fixes 0004371: Changing Hole profile from ISO to nothing is not possible: "Hole: Cannot get value from invalid enumeration"	Affected Issues 0004371
	mod - src/Mod/PartDesign/App/FeatureHole.cpp	Diff File
FreeCAD: master 1f0b7793 2020-10-18 15:08:18 wmayer Details Diff	Revert "PartDesign: [skip ci] fixes 0004371: Changing Hole profile from ISO to nothing is not possible: "Hole: Cannot get value from invalid enumeration"" This reverts commit fe3f1b51b7be58367d08c5bb0f9f9d292671bb39.	Affected Issues 0004371
	mod - src/Mod/PartDesign/App/FeatureHole.cpp	Diff File

Date Modified	Username	Field	Change
2020-06-13 21:50	n.rottgardt@gmail.com	New Issue
2020-06-13 21:50	n.rottgardt@gmail.com	File Added: 2020-06-13 13_16_02-Window.png
2020-06-13 21:50	n.rottgardt@gmail.com	File Added: 2020-06-13 13_15_47-Window.png
2020-06-13 21:50	n.rottgardt@gmail.com	File Added: Soxos GPS Halter 4-1.FCStd
2020-06-14 13:38	Kunda1	Summary	Changing Hole profil from Iso to nothing is not possible: "Hole: Cannot get value from invalid enumeration" => Changing Hole profile from ISO to nothing is not possible: "Hole: Cannot get value from invalid enumeration"
2020-06-14 16:24	chrisb	Note Added: 0014539
2020-09-23 09:30	wmayer	Changeset attached	=> FreeCAD master fe3f1b51
2020-09-23 09:30	wmayer	Note Added: 0014765
2020-09-23 09:30	wmayer	Assigned To	=> wmayer
2020-09-23 09:30	wmayer	Status	new => closed
2020-09-23 09:30	wmayer	Resolution	open => fixed
2020-10-18 15:30	wmayer	Changeset attached	=> FreeCAD master 1f0b7793
2020-10-18 15:30	wmayer	Note Added: 0014908
2020-10-19 14:53	wmayer	Note Added: 0014913

n.rottgardt@gmail.com 2020-06-13 21:50 reporter	2020-06-13 13_16_02-Window.png (45,417 bytes) 2020-06-13 13_16_02-Window.png (45,417 bytes) 2020-06-13 13_15_47-Window.png (93,621 bytes) 2020-06-13 13_15_47-Window.png (93,621 bytes) Soxos GPS Halter 4-1.FCStd (488,584 bytes)

chrisb 2020-06-14 16:24 developer ~0014539	This fails only if the change is made to an existing hole.

wmayer 2020-09-23 09:30 administrator ~0014765	Fix committed to master branch.

wmayer 2020-10-18 15:30 administrator ~0014908	Fix committed to master branch.

wmayer 2020-10-19 14:53 administrator ~0014913	Some additional changes: https://github.com/FreeCAD/FreeCAD/commit/c0b2188ada1d76b834ad1acf0c0df0392ae7eab0 https://github.com/FreeCAD/FreeCAD/commit/99dd4460c56f4697241bef1d4a4645043c17171c https://github.com/FreeCAD/FreeCAD/commit/6e6f2c8a0a1be3a3a2449ea3b7b6ee4465bd5cce https://github.com/FreeCAD/FreeCAD/commit/a29d834bd31fcf5dedfceb159c4d36c18194197f https://github.com/FreeCAD/FreeCAD/commit/ec46265bc36643265ddd3cee5c9379caa016e012